Show channel/topic at top of channel/topic action sheet #1877
Conversation
Fixes zulip#1533. This excludes the channel description for now; that'll be more complicated to implement, involving zulip#488.
chrisbobbe
force-pushed
the
pr-channel-topic-action-sheet-headers
branch
from
7f6a80d to
96b3eba
Compare
There was a problem hiding this comment.
Thanks @chrisbobbe! LGTM, and tests great. Moving over to Greg's review.
rajveermalviya
added
integration review
There was a problem hiding this comment.
Thanks! Small code comments below.
I feel like we might want to include the channel name/icon when showing the topic, too. Consider the case of the combined feed or another interleaved view.
Which reminds me: this should get UX review from Alya (if it hasn't already in a chat thread).
| ]; | ||
|
|
||
| _showActionSheet(pageContext, buttonSections: buttonSections); | ||
| Widget header; |
| header = BottomSheetHeader( | ||
| buildTitle: (baseStyle) => Text( | ||
| style: baseStyle.copyWith(fontStyle: FontStyle.italic), | ||
| store.realmEmptyTopicDisplayName)); |
There was a problem hiding this comment.
action_sheet: Show topic in topic action sheet
Fixes #1533.
This excludes the channel description for now; that'll be more
complicated to implement, involving #488.
That last bit belongs in the commit message for the channel action sheet, right?
Let's also track that follow-up somewhere — either explicitly in #488, or as its own small issue.
|
Hmm, we don't show the channel name in topic menus in the web app, but you can seem more context around the menu there. Including the name of the channel makes sense to me for mobile. |
|
Looks good to me otherwise! |
Fixes #1533.