action_sheet: Put mark-channel-as-read button at top of action sheet #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
integration review
|
Thanks! Looks good; merging. |
gnprice
force-pushed
the
pr-mark-channel-as-read-first
branch
from
a2fd25f to
766f071
Compare
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Sep 25, 2025
…send This fixes part of the "second buggy behavior" that I described in zulip#1789: specifically, it fixes that behavior when the self-user doesn't have permission to send messages in the channel. Later, for the case where there *is* permission to send messages, we should use a different banner label, like "Replies to your messages will not appear automatically." I think it's smoothest not to touch that case until we've fixed the "first" and "third" parts of zulip#1798, because those are bugs in the send-message experience. Fixes-partly: zulip#1798
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Oct 1, 2025
…send This fixes part of the "second buggy behavior" that I described in zulip#1789: specifically, it fixes that behavior when the self-user doesn't have permission to send messages in the channel. Later, for the case where there *is* permission to send messages, we should use a different banner label, like "Replies to your messages will not appear automatically." I think it's smoothest not to touch that case until we've fixed the "first" and "third" parts of zulip#1798, because those are bugs in the send-message experience. Fixes-partly: zulip#1798
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Oct 9, 2025
…send This fixes part of the "second buggy behavior" that I described in zulip#1789: specifically, it fixes that behavior when the self-user doesn't have permission to send messages in the channel. Later, for the case where there *is* permission to send messages, we should use a different banner label, like "Replies to your messages will not appear automatically." I think it's smoothest not to touch that case until we've fixed the "first" and "third" parts of zulip#1798, because those are bugs in the send-message experience. Fixes-partly: zulip#1798
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Oct 9, 2025
…send This fixes part of the "second buggy behavior" that I described in zulip#1789: specifically, it fixes that behavior when the self-user doesn't have permission to send messages in the channel. Later, for the case where there *is* permission to send messages, we should use a different banner label, like "Replies to your messages will not appear automatically." I think it's smoothest not to touch that case until we've fixed the "first" and "third" parts of zulip#1798, because those are bugs in the send-message experience. Fixes-partly: zulip#1798
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this pull request
Oct 10, 2025
…send This fixes part of the "second buggy behavior" that I described in zulip#1789: specifically, it fixes that behavior when the self-user doesn't have permission to send messages in the channel. Later, for the case where there *is* permission to send messages, we should use a different banner label, like "Replies to your messages will not appear automatically." I think it's smoothest not to touch that case until we've fixed the "first" and "third" parts of zulip#1798, because those are bugs in the send-message experience. Fixes-partly: zulip#1798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6812-34593&m=dev
cc @alya