Get confirmation before marking an interleaved feed as unread

[gnprice]

The "Mark all as read" button at the bottom of the message feed can be easy to hit by accident. The result can be quite annoying, if the feed was showing an interleaved narrow (one that spans conversations, especially the combined feed); it can be difficult to get the state back to what it was.

We therefore want to show a confirmation dialog in this case, like we do in the web app.

For the logic of when to show it, see:
#mobile > mark all messages as read @ 💬
and unread_ops.mark_as_unread_from_here in the web app.

For the text of the dialog, see:
#mobile > mark all messages as read @ 💬
and then for the details of "{N} messages", see the same sources as for the logic.

References

• Chat thread: #mobile > mark all messages as read @ 💬

[komal-uniqode]

Hey, @gnprice, @chrisbobbe . I get the context of this issue and yes this makes complete sense to add a conformation modal. Only thing I am not getting is, where to find designs for this conformation modal. Would be great if you can add a screenshot or some design file link.

Also please assign this to me, would be happy to work on this.

Thanks.

[gnprice]

Sure, thanks.

For the appearance of the modal, we'll want it to be similar to the other dialogs in the app; git grep -i dialog lib/ will find examples of existing dialogs, and if you make the new dialog in a similar way then your code should get to avoid having to specify much about the appearance.

For any follow-up questions about how the UI should look or behave, a thread in #mobile-design on chat.zulip.org would be the best venue. (See https://zulip.com/development-community/#mobile-app .)

[komal-uniqode]

As far as I understood, we need to show the conformation modal with the following content :
Heading : Mark messages as read ?
message : {N} messages will be marked as read.
primary button : Done
secondary button : Cancel

Also regarding the logic of when to show this conformation modal, we will show this when user taps on the "Mark all messages as read" inside the combined feed only. Not when the user is inside the search view and inside the conversation view.

Please help me if there are other places we need this modal to appear other than combined feed.

cc : @gnprice , @alya

[alya]

Combined feed is a fine starting point; we can extend this later if desired.

[gnprice]

The desired logic for when to show it is described here (as linked in the issue description):

we'd always show the confirmation dialog when not in a conversation view.

I don't think it'll be any harder to implement that logic correctly than it would be to do it only for the combined feed, so we should do the intended thing from the beginning.

In particular, a search view is not a conversation view, so the dialog should appear there.