Generate server certs for MQTT test container #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seanstoppable
changed the title
Seanstoppable
force-pushed
the
ssmith/generatecerts
branch
2 times, most recently
from
063e6dc to
60c1ee5
Compare
This generates server certificates for integration tests, rather than rely on ones checked into the repo
Seanstoppable
force-pushed
the
ssmith/generatecerts
branch
from
60c1ee5 to
7cfedfb
Compare
phillip-stephens
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates server certificates for integration tests, rather than rely on ones checked into the repo
My org has a pretty strict policy around certificates being checked in to a repo, and discovered this when trying to merge recent changes. To work around this, I suggest we generate the certificates as part of the server startup instead.
Bonus, tests won't fail whenever the expiration of the existing certificate expires.