feat: Add Email Headers #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimiDumo
force-pushed
the
feat/add_email_headers
branch
from
387de94 to
0c19631
Compare
|
Can you follow CODING_GUIDELINES.md? |
Bisht13
reviewed
Sep 19, 2024
src/command_templates.rs
Outdated
| } | ||
|
|
||
| // Generated by Github Copilot! | ||
| pub fn uint_to_decimal_string(uint: u128, decimal: usize) -> String { |
There was a problem hiding this comment.
Can you check if this functions exists in converters.rs if not can you shift it there?
Bisht13
reviewed
Sep 19, 2024
src/proof.rs
Outdated
| Ok((proof, pub_signals)) | ||
| } | ||
|
|
||
| pub fn calculate_default_hash(input: &str) -> String { |
There was a problem hiding this comment.
Check if exists in cryptos.rs if not add
Bisht13
reviewed
Sep 19, 2024
src/proof.rs
Outdated
| hash_code.to_string() | ||
| } | ||
|
|
||
| pub fn calculate_account_salt(email_addr: &str, account_code: &str) -> String { |
There was a problem hiding this comment.
Check if exists in cryptos.rs if not add
Add AI generated comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds email headers to ParsedEmail.
Moves functionality from
ether-email-authto utilsFixes # (issue)
Type of change
How Has This Been Tested?
Checklist: