-
Notifications
You must be signed in to change notification settings - Fork 121
Description
The ff_derive
derived PrimeField
implementation fails to derive a sqrt function for primes p = 5 (mod 8)
and p = 9 (mod 16)
, resulting in a compile-time error for these cases. According to the introduction of IACR Preprint 2012/685 (the cited reference for the algorithms used for the p = 3 (mod 4)
and p = 1 (mod 16)
cases), efficient algorithms do exist for computing square roots over these primes; however, these algorithms are not currently implemented here.
In Issue #33, this limitation is noted explicitly, so it may be that the desired use cases for this library don't require full coverage of odd primes. I just wanted to check whether this is an intentional omission for maintainability, or if it's simply a feature that hasn't been added yet. If it's the latter and maintainers are interested, I might be able to assemble a pull request.