Skip to content

Conversation

HDauven
Copy link

@HDauven HDauven commented Oct 18, 2023

Upstream, we make use of Hash derive on Scalar.

Scalar uses a custom PartialEq for constant-time comparison, but derives Hash, which leads to this Clippy warning downstream for us.

My proposed solution is to implement a custom Hash for Scalar that standardizes on the underlying values. A test is added to ensure consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant