Undocumented use flush option in fs.writeFile() #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WULCAN
requested changes
Apr 6, 2025
Collaborator
WULCAN
left a comment
WULCAN
left a comment
There was a problem hiding this comment.
Thank you, there's just one more place that needs to change to update Node.
WULCAN
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@WULCAN find this interesting case in node where fs/promises writeFile that can effected us that we might write files but git commit and push the older version of these files related to a new flush option in writeFile: nodejs/node#50009
Changes
write files with flush option true as
fs(path, body, { flush: true });This change required upgrade to at least Node 21 so I updated to Node 22