Skip to content

Conversation

Finomnis
Copy link
Contributor

@Finomnis Finomnis commented Sep 30, 2024

Due to the following in line 45, FlexSPI2 actually returned the frequency of FlexSPI1:

peripheral = (clock_name & IMX_CCM_PERIPHERAL_MASK);

The fix is to adjust the switch case to match the #1 + instance scheme of the other clocks.

Needs backporting to 3.7.

Fixes ##79288

@danieldegrasse
Copy link
Contributor

danieldegrasse commented Sep 30, 2024

Thanks for the fix, you have a few compliance issues that need to be fixed (you can fix up this commit and force push over the branch you sent the PR from):

61de4a34fba4b0a6a7958a60bb3bc12411f2095a: author email (Martin Stumpf [email protected]) needs to match one of the signed-off-by entries.
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details

1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Compliance error, check for error messages in the "Run Compliance Tests" step
You can run this step locally with the ./scripts/ci/check_compliance.py script.

As the error above hints, you can also run ./scripts/ci/check_compliance.py locally to test if you've fixed these errors (provided you install the python dependencies given in scripts/requirements-compliance.txt using pip)

The clock control mcux rev2 returns FlexSPI1 clock rate when FlexSPI2
clock rate is requested.

Signed-off-by: Martin Stumpf <[email protected]>
@Finomnis
Copy link
Contributor Author

Thanks for the fix, you have a few compliance issues that need to be fixed (you can fix up this commit and force push over the branch you sent the PR from):

61de4a34fba4b0a6a7958a60bb3bc12411f2095a: author email (Martin Stumpf [email protected]) needs to match one of the signed-off-by entries.
Error: See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
1: UC2 Commit message does not contain a 'Signed-off-by:' line
1: UC6 Commit message body is empty, should at least have 1 line(s).
3: B6 Body message is missing
Compliance error, check for error messages in the "Run Compliance Tests" step
You can run this step locally with the ./scripts/ci/check_compliance.py script.

As the error above hints, you can also run ./scripts/ci/check_compliance.py locally to test if you've fixed these errors (provided you install the python dependencies given in scripts/requirements-compliance.txt using pip)

This script (on windows) gives me a segmentation fault :/

I hope it's correct now

@danieldegrasse
Copy link
Contributor

This script (on windows) gives me a segmentation fault :/

I hope it's correct now

Ah yeah, sorry- I should have made that clear in my first message, the script is only tested in linux :/

@Finomnis
Copy link
Contributor Author

Finomnis commented Oct 1, 2024

@danieldegrasse Will this be backported to 3.7? We encountered this issue at work on the 3.7 LTS release, and would like to stay upstream if possible and not on our own fork.

@decsny
Copy link
Member

decsny commented Oct 1, 2024

@danieldegrasse Will this be backported to 3.7? We encountered this issue at work on the 3.7 LTS release, and would like to stay upstream if possible and not on our own fork.

to do that then you need to open a bug report issue and link it to this PR, and then have someone add the backport tag to this PR

@decsny decsny assigned mmahadevan108 and unassigned nordic-krch Oct 4, 2024
@fabiobaltieri fabiobaltieri merged commit 4ec2661 into zephyrproject-rtos:main Oct 4, 2024
26 checks passed
@Finomnis Finomnis deleted the fix_mcux_cc_get_flexspi branch October 5, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Clock Control backport v3.7-branch Request backport to the v3.7-branch platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants