drivers: dai: sai: don't crash on underrun/overrun #77236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentiuM1234
requested review from
kv2019i,
marcinszkudlinski and
abonislawski
as code owners
zephyrbot
requested review from
danieldegrasse,
dbaluta,
decsny,
dleach02,
iuliana-prodan,
juimonen,
lgirdwood,
manuargue,
MarkWangChinese and
mmahadevan108
dbaluta
reviewed
Aug 23, 2024
| ((dir) == DAI_DIR_RX ?\ | ||
| SAI_RxClearStatusFlags(UINT_TO_I2S(regmap), which) :\ | ||
| SAI_TxClearStatusFlags(UINT_TO_I2S(regmap), which)) | ||
|
|
||
| /* used to retrieve the SYNC direction. Use this macro when you know for sure |
There was a problem hiding this comment.
@LaurentiuM1234 change looks good to me. Will approve once this warning is fixed.
There was a problem hiding this comment.
Tweaked the formatting of the macro as the clang-format suggestion did improve the code readability IMO. Warning still persists because of the position of \. I don't think this new suggestion improves code readability so unless we're required to make new code clang-format-compliant I see no reason to go with it.
LaurentiuM1234
force-pushed
the
fix/sai_underrun_overrun
branch
2 times, most recently
from
cfe549b to
f5b6f14
Compare
TX/RX FIFO underrun shouldn't crash the RTOS when it occurs. Also, since this can also happen under "normal" conditions (i.e: DMA doesn't copy data fast enough from/to SAI's FIFOs) the software should be able to recover from it. As such: 1) Remove `z_irq_spurious()` call. 2) Clear error flag 3) De-escalate error message to warning message Signed-off-by: Laurentiu Mihalcea <[email protected]>
dbaluta
approved these changes
Aug 26, 2024
dleach02
approved these changes
Aug 27, 2024
|
created bug report (#77633) for backporting |
iuliana-prodan
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TX/RX FIFO underrun shouldn't crash the RTOS when it occurs. Also, since this can also happen under "normal" conditions (i.e: DMA doesn't copy data fast enough from/to SAI's FIFOs) the software should be able to recover from it.
As such:
1) Remove
z_irq_spurious()call.2) Clear error flag
3) De-escalate error message to warning message
Fixes #77633