Bluetooth: Host: Fix ISO buffers leak #77008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disconnected while sending data, if ISO doesn't get the number of completed packets it will not call `process_unack_tx` and thus will leak TX context. Fix that by setting the connection state in ISO disconnection which will trigger a call to `process_unack_tx`. Signed-off-by: Théo Battrel <[email protected]>
theob-pro
added
bug
theob-pro
force-pushed
the
prop-tx-iso-frag-fix
branch
from
e2d8225 to
8aaddb9
Compare
|
|
Oh yeah true, thanks! |
alwa-nordic
previously approved these changes
Aug 13, 2024
jhedberg
previously approved these changes
Aug 13, 2024
theob-pro
force-pushed
the
prop-tx-iso-frag-fix
branch
from
8aaddb9 to
1b09f4b
Compare
When sending data using ISO and the data is fragmented, if the connection is cut before all the fragments are sent, the data buffer will be leaked. Fix the issue by unref'ing the buffer when ISO is not in a connected state. Signed-off-by: Théo Battrel <[email protected]>
theob-pro
force-pushed
the
prop-tx-iso-frag-fix
branch
from
1b09f4b to
f008309
Compare
jori-nordic
previously approved these changes
Aug 14, 2024
jhedberg
previously approved these changes
Aug 14, 2024
Thalley
reviewed
Aug 14, 2024
This test create a setup where an ISO broadcaster will send fragmented data and get stopped after sending the first fragment and repeating that operation multiple time to verify that buffers are not leaked. Signed-off-by: Théo Battrel <[email protected]>
theob-pro
force-pushed
the
prop-tx-iso-frag-fix
branch
from
f008309 to
1fca0b9
Compare
jori-nordic
approved these changes
Aug 16, 2024
jhedberg
approved these changes
Aug 16, 2024
Thalley
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77006
Fixes #77007
Add a test to reproduce those issues.