[Backport v1.14-branch] Bluetooth: controller: Fix regression in ctrl tx queue handling #34122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
cvinayak
added
area: Bluetooth
area: Bluetooth Controller
Backport
cvinayak
changed the title
|
Can you rebase now that the doc building is fixed. |
Fix control Tx buffer leak into data Tx pool that happens after a cross-over control procedure response was paused due to currently active encryption setup procedure, and a new control Tx PDU in addition to the paused one is enqueued thereafter. When the control tx PDUs is resumed but not yet enqueued towards the radio, if there is a new control Tx PDU enqueued then the paused control Tx PDU is not set as the head of the control PDUs in the Tx queue. This caused the paused control Tx PDU to be associated with data Tx pool, hence causing the incorrect release into data Tx pool. Relates to the commit bff76b4 ("Bluetooth: controller: split: Fix control tx queue handling"), and to the commit 6991d09 ("Bluetooth: controller: Fix control tx queue handling"), and to the commit 7f727ac ("Bluetooth: controller: Fix regression in ctrl tx queue handling"). Fixes zephyrproject-rtos#32898. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
backport-33310-to-v1.14-branch
branch
from
ddfaf15 to
1a93b72
Compare
thoh-ot
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix control Tx buffer leak into data Tx pool that happens
after a cross-over control procedure response was paused due
to currently active encryption setup procedure, and a new
control Tx PDU in addition to the paused one is enqueued
thereafter.
When the control tx PDUs is resumed but not yet enqueued
towards the radio, if there is a new control Tx PDU enqueued
then the paused control Tx PDU is not set as the head of the
control PDUs in the Tx queue. This caused the paused control
Tx PDU to be associated with data Tx pool, hence causing the
incorrect release into data Tx pool.
Relates to the commit bff76b4 ("Bluetooth: controller:
split: Fix control tx queue handling"), and to the
commit 6991d09 ("Bluetooth: controller: Fix control tx
queue handling"), and to the
commit 7f727ac ("Bluetooth: controller: Fix regression
in ctrl tx queue handling").
Fixes #32898.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]