Bluetooth: controller: Fix channel map and interval check in CONNECT_IND PDU #33278
+37
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the leak of node rx buffer used to generate the connection complete and CSA#2 event introduced in the commit 4a5f263 ("Bluetooth: controller: split: Validate chan map and hop value") and the commit 94d5f08 ("Bluetooth: controller: fixing error re. all zero chmap in conn-ind"). Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Check for interval value in received CONNECT_IND PDU and ignore connection setup. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
requested review from
carlescufi,
kruithofa and
thoh-ot
as code owners
cvinayak
added
bug
kruithofa
approved these changes
Mar 15, 2021
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.14-branch v1.14-branch
# Navigate to the new working tree
cd .worktrees/backport-v1.14-branch
# Create a new branch
git switch --create backport-33278-to-v1.14-branch
# Cherry-pick the merged commits of this pull request and resolve the conflicts
git cherry-pick 813b24157b3e6bd51250cadabd96d087bf284caa~2..813b24157b3e6bd51250cadabd96d087bf284caa
# Push it to GitHub
git push --set-upstream origin backport-33278-to-v1.14-branch
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.14-branchThen, create a pull request where the |
8 tasks
|
@cvinayak nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the leak of node rx buffer used to generate the
connection complete and CSA#2 event introduced in the
commit 4a5f263 ("Bluetooth: controller: split: Validate
chan map and hop value") and the
commit 94d5f08 ("Bluetooth: controller: fixing error
re. all zero chmap in conn-ind").
Bluetooth: controller: Fix interval check in CONNECT_IND PDU
Check for interval value in received CONNECT_IND PDU and
ignore connection setup.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]