Skip to content

Conversation

erbr-ot
Copy link
Contributor

@erbr-ot erbr-ot commented Aug 12, 2020

When a connect indication contains a channel map of all zeros, the adv->conn is left NULL'ed after return and next connect attempt leads to a crash.

This was identified via the Sweyntooth test suite - executing the script re. issue 6.14 towards an Oticon target.

Signed-off-by: Erik Brockhoff [email protected]

Copy link
Contributor

@cvinayak cvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this issue could be in v1.14 legacy controller, could you please create a simple GH issue for v1.14 legacy controller?
Otherwise the changes here look good to me.

@cvinayak
Copy link
Contributor

nitpick.... Commit message title "Bluetooth: controller: ... "

When a connect indication contains a channel map of all zeros, the
adv->conn is left NULL'ed after return and next connect attempt leads
to a crash.

This was identified via the Sweyntooth test suite executing the script
re. issue 6.14 towards an Oticon target.

Signed-off-by: Erik Brockhoff <[email protected]>
@erbr-ot erbr-ot changed the title Bluetooth: ctrl: fixing error re. all zero chmap in conn-ind Bluetooth: controller: fixing error re. all zero chmap in conn-ind Aug 12, 2020
@carlescufi carlescufi merged commit 94d5f08 into zephyrproject-rtos:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants