Bluetooth: controller: split: Fix Tx Ctrl PDU leak #21374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overlapping Feature Exchange requested by host with Encryption Setup requested by the application caused the controller to corrupt its Tx queue leading to Tx Ctrl PDU buffers from leaking from the system. Fixes zephyrproject-rtos#21299. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
added
bug
Fix LENGTH_RSP and PING_RSP to be send after Encryption Setup under the cases where LENGTH_REQ or PING_REQ cross- over with ENC_REQ in the same connection event. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix compiler warnings when PHY update feature is not selected. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
thoh-ot
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlapping Feature Exchange requested by host with
Encryption Setup requested by the application caused the
controller to corrupt its Tx queue leading to Tx Ctrl PDU
buffers from leaking from the system.
Fixes #21299.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]