Skip to content

Conversation

cvinayak
Copy link
Contributor

Fix the implementation of slow encryption setup design
alternative to send ENC_RSP PDU before sending REJECT_IND
or REJECT_EXT_IND PDU.

Fixes #19917.

Signed-off-by: Vinayak Kariappa Chettimada [email protected]

@cvinayak cvinayak added bug The issue is a bug, or the PR is fixing a bug area: Bluetooth RFC Request For Comments: want input from the community platform: nRF Nordic nRFx backport v1.14-branch labels Oct 21, 2019
@cvinayak cvinayak added this to the v2.1.0 milestone Oct 21, 2019
@cvinayak cvinayak added the DNM This PR should not be merged (Do Not Merge) label Oct 21, 2019
@cvinayak
Copy link
Contributor Author

@rugeGerritsen Please verify if this PR resolves #19917

@rugeGerritsen
Copy link
Contributor

@cvinayak. I still see the same issue. The controller is sending the REJECT_EXT_IND in the next connection event after receiving LL_ENC_REQ. I replicated the setup described in #19917. Tested on commit a0e2fc5589820728f2aad428272ad82399fb14e3 using nrf52840_pca10056

@cvinayak
Copy link
Contributor Author

cvinayak commented Oct 22, 2019

@rugeGerritsen Sorry, this is a fix for CONFIG_BT_LL_SW_LEGACY=y, not for CONFIG_BT_LL_SW_SPLIT (which still have few old commits to be ported before I can have this fix in there).

@rugeGerritsen
Copy link
Contributor

Quickly verified that the fix works for CONFIG_BT_LL_SW_LEGACY.

@cvinayak cvinayak force-pushed the github_enc_rsp_rej_ind_fix branch 3 times, most recently from 8a97c4e to a7e1fa6 Compare November 5, 2019 11:59
Fix the implementation of slow encryption setup design
alternative to send ENC_RSP PDU before sending REJECT_IND
or REJECT_EXT_IND PDU.

Fixes zephyrproject-rtos#19917.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak force-pushed the github_enc_rsp_rej_ind_fix branch from a7e1fa6 to dca0769 Compare November 6, 2019 13:16
@cvinayak cvinayak removed DNM This PR should not be merged (Do Not Merge) RFC Request For Comments: want input from the community labels Nov 6, 2019
@cvinayak
Copy link
Contributor Author

@thoh-ot can you approve this, split one has been already merged before this one.

@nashif nashif merged commit 3805290 into zephyrproject-rtos:master Nov 19, 2019
@cvinayak cvinayak deleted the github_enc_rsp_rej_ind_fix branch March 1, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluetooth: Controller: Missing LL_ENC_RSP after HCI LTK Negative Reply
5 participants