ST LIS2DUX12 driver: will not correctly read values on big-endian HW

[ragrus-nbl]

Describe the bug
ST LIS2DUX12 accelerometer driver makes unnecessary "little-endian to CPU endian" conversion. This will lead to incorrect readings on big-endian HW.

I believe these sys_le16_to_cpu() conversions are not needed: three here and one there.

That's because values are converted to CPU endianness in the hal_st code: here and there correspondingly.

I can't reproduce/check this in practice as I don't have a big-endian HW with this sensor.

To Reproduce
Read any sensor channel (e.g., SENSOR_CHAN_DIE_TEMP) on big-endian HW.

Environment

• Zephyr 3.7.0-rc2

[avisconti]

Well, the BE/LE stuff is always confusing me.

The STDC drivers (included in zephyr as stmemsc in hal_st module) have indeed the purpose to abstract from the platform details. So, they should in fact already solve the BE/LE related issue, and I would like to check it on some BE platform (I do not have any) to see whether this is really the case. But I agree that from zephyr driver standpoint that call (i.e sys_le16_to_cpu()) should not be there as the stmemsc HAL should already take care of the byte swapping as I mentioned earlier...

Let me think more about it. Thanks for pointing this out.

[erwango]

Removing STM32 label as this is not related to STM32 SoC.