move short-hand aliases from --generate-completion to separate --generate-aliases flag
#4468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
zellij setup --generate-completion zshincludesEquivalently for
zellij setup --generate-completion bashandzellij setup --generate-completion bash.Those are aliases and not completions and in my opinion should not be included in a
--generate-completioncommand.In particular this is problematic for packaging zellij, as these aliases will end up in the system-wide command namespace, and manually editing the completions file to remove them requires root and is only temporary.
My suggestion with this PR is to move them to a separate
--generate-aliasescommand, though I'd also consider it a valid option to just remove them, since in my opinion short-hand aliases like that should be up to the user to define themselves.