fix(web): set secure cookie flag only for https #4345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tlinford - mind giving this a test on safari to make sure we fixed the issue you found? |
|
Seems fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would set the
securecookie flag (meaning the cookie should only be sent on https connections) to our session_token cookie whether we were on http or https. Most browsers have a "localhost exception" for this, meaning they send secure cookies on non-https connections so long as they are to localhost. Safari does not have this exception, so users were unable to log-in before they set an https certificate.This fixes the issue by conditionally setting the
secureflag depending on whether the connection is https or not. Since the web client does not perform any http (or indeed, any remote) requests other than to the server, this is not considered risky.