fix(terminal): handle omitted flags in kitty keyboard protocol push sequence #4334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equence The CSI > u sequence (push) should default omitted flags to 0 per the Kitty keyboard protocol specification. Previously, omitted flags incorrectly defaulted to 1, causing progressive enhancements to be enabled when they should remain disabled. This fix ensures push with no flags (printf "\e[>u") correctly sets flags to 0, matching the protocol specification and making push behavior consistent with the existing CSI = u implementation. Author: Anton Afanasyev <[email protected]>
|
I think some basic tests for this functionality would be useful, but I am not sure of a good way to write them. Open to suggestions there. |
aymanbagabas
approved these changes
Aug 5, 2025
|
Hi there! I've encountered this working on Bubble Tea v2 and had to make it use the CC/ @imsnif |
|
Good catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CSI > usequence (push) should default omitted flags to0per the Kitty keyboard protocol specification. Previously, omitted flags incorrectly defaulted to 1, causing progressive enhancements to be enabled when they should remain disabled.This fix ensures push with no flags (
printf "\e[>u") correctly sets flags to0, matching the protocol specification and making push behavior consistent with the existingCSI = uimplementation introduced in #3942.Fixes #4333.