fix(themes): improve solarized-dark contrast and color consistency #4208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solarized-dark theme has several issues: - The selection for tables and lists is not visible - It is using base values that should not be present in the dark version of the theme - The normal relationship for background and body text is base03:base0 and base02:base1 for highlighted content This is making the appearance of the solarized-dark theme very inconsistent and wrong. To fix: - Standardize text color to base1 (147 161 161) for better readability - Fix ribbon_unselected background from base3 to base1 for dark theme consistency - Improve selection backgrounds using base02 for better contrast Signed-off-by: Carlo Caione <[email protected]>
|
Is there any interest in this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solarized-dark theme has several issues:
This is making the appearance of the solarized-dark theme very inconsistent and wrong.
To fix:
Before:
After: