helix: Change selection cloning #38090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Could this also solve #37332 ? |
Yes, thank you. |
kubkon
force-pushed
the
helix-selection-cloning
branch
from
f99dc38 to
a65c77b
Compare
kubkon
force-pushed
the
helix-selection-cloning
branch
from
a65c77b to
cb2ac37
Compare
kubkon
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Looks great! I've reorganised the code a little bit so that we keep this helix-only rather than adding new actions to the editor - if there ever is a need we can extract it from helix into the editor proper. But until such time I would be more comfortable narrowly scoping any helix-related changes to the helix module.
xipeng-jin
pushed a commit
to xipeng-jin/zed
that referenced
this pull request
Oct 17, 2025
Closes zed-industries#33637 Closes zed-industries#37332 and solves part of zed-industries#33580 (comment) This improves the "C" and "alt-C" actions to work like helix. It also adds "," which removes all but the newest cursors. In helix the one that's left would be the primary selection, but I don't think that has an equivalent yet, so this simulates what would be the primary selection if it was never cycled with "(" ")". Release Notes: - Improved multicursor creation and deletion in helix mode --------- Co-authored-by: Jakub Konka <[email protected]>
P1n3appl3
pushed a commit
to P1n3appl3/zed
that referenced
this pull request
Oct 18, 2025
Closes zed-industries#33637 Closes zed-industries#37332 and solves part of zed-industries#33580 (comment) This improves the "C" and "alt-C" actions to work like helix. It also adds "," which removes all but the newest cursors. In helix the one that's left would be the primary selection, but I don't think that has an equivalent yet, so this simulates what would be the primary selection if it was never cycled with "(" ")". Release Notes: - Improved multicursor creation and deletion in helix mode --------- Co-authored-by: Jakub Konka <[email protected]>
|
Thank you for this!/gen It's a small thing but still something I missed from Helix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33637
Closes #37332
and solves part of #33580 (comment)
This improves the "C" and "alt-C" actions to work like helix.
It also adds "," which removes all but the newest cursors. In helix the one that's left would be the primary selection, but I don't think that has an equivalent yet, so this simulates what would be the primary selection if it was never cycled with "(" ")".
Release Notes: