Skip to content

lsp: Add support for dynamic registration of rename capability #25610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

osiewicz
Copy link
Contributor

While looking at Biome LSP implementation I've noticed that they register their rename capability dynamically, which we don't handle.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 25, 2025
@osiewicz osiewicz changed the title lsp: add support for dynamic registration of rename capability lsp: Add support for dynamic registration of rename capability Feb 25, 2025
@osiewicz osiewicz enabled auto-merge (squash) February 25, 2025 23:39
@osiewicz osiewicz merged commit 3db18ff into main Feb 25, 2025
13 checks passed
@osiewicz osiewicz deleted the lsp-add-prepare-rename branch February 25, 2025 23:54
@kasimir-dka
Copy link

Hi @osiewicz - I wonder if this change is related to renaming not working any more?
image
If I disable Biome LSP, then F2 renaming works as it used to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants