Add the ability for tasks to target the center pane #22004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where tasks would have the wrong working directory set to a file when spawning a task while looking at an external file
cla-bot
bot
added
the
cla-signed
mikayla-maki
force-pushed
the
add-center-pane-target-for-tasks
branch
from
8af6277 to
f743634
Compare
1 task
Merged
SomeoneToIgnore
added a commit
that referenced
this pull request
Dec 14, 2024
|
😍 Thank you, thank you, thank you, @mikayla-maki ! This is so great. |
1 task
SomeoneToIgnore
added a commit
that referenced
this pull request
Dec 16, 2024
Follow-up of #22004 * Reuse center terminals for tasks, when requested * Extend task templates with `RevealTarget`, moving it from `TaskSpawnTarget` into the core library * Use `reveal_target` instead of `target` to avoid misinterpretations in the task template context * Do not expose `SpawnInTerminal` to user interface, avoid it implementing `Serialize` and `Deserialize` * Remove `NewCenterTask` action, extending `task::Spawn` interface instead * Do not require any extra unrelated parameters during task resolution, instead, use task overrides on the resolved tasks on the modal side * Add keybindings for opening the task modal in the `RevealTarget::Center` mode Release Notes: - N/A
lino-levan
pushed a commit
to the-code-editor-company/editor
that referenced
this pull request
Dec 16, 2024
…2004) Closes zed-industries#20060 Closes zed-industries#20720 Closes zed-industries#19873 Closes zed-industries#9445 Release Notes: - Fixed a bug where tasks would be spawned with their working directory set to a file in some cases - Added the ability to spawn tasks in the center pane, when spawning from a keybinding: ```json5 [ { // Assuming you have a task labeled "echo hello" "ctrl--": [ "task::Spawn", { "task_name": "echo hello", "target": "center" } ] } ] ```
lino-levan
pushed a commit
to the-code-editor-company/editor
that referenced
this pull request
Dec 16, 2024
zed-industries#21706 was merged after zed-industries#22004 and the CI missed that. Release Notes: - N/A
lino-levan
pushed a commit
to the-code-editor-company/editor
that referenced
this pull request
Dec 16, 2024
Follow-up of zed-industries#22004 * Reuse center terminals for tasks, when requested * Extend task templates with `RevealTarget`, moving it from `TaskSpawnTarget` into the core library * Use `reveal_target` instead of `target` to avoid misinterpretations in the task template context * Do not expose `SpawnInTerminal` to user interface, avoid it implementing `Serialize` and `Deserialize` * Remove `NewCenterTask` action, extending `task::Spawn` interface instead * Do not require any extra unrelated parameters during task resolution, instead, use task overrides on the resolved tasks on the modal side * Add keybindings for opening the task modal in the `RevealTarget::Center` mode Release Notes: - N/A
SomeoneToIgnore
added a commit
that referenced
this pull request
Dec 16, 2024
helgemahrt
pushed a commit
to helgemahrt/zed
that referenced
this pull request
Dec 18, 2024
Follow-up of zed-industries#22004 * Reuse center terminals for tasks, when requested * Extend task templates with `RevealTarget`, moving it from `TaskSpawnTarget` into the core library * Use `reveal_target` instead of `target` to avoid misinterpretations in the task template context * Do not expose `SpawnInTerminal` to user interface, avoid it implementing `Serialize` and `Deserialize` * Remove `NewCenterTask` action, extending `task::Spawn` interface instead * Do not require any extra unrelated parameters during task resolution, instead, use task overrides on the resolved tasks on the modal side * Add keybindings for opening the task modal in the `RevealTarget::Center` mode Release Notes: - N/A
helgemahrt
pushed a commit
to helgemahrt/zed
that referenced
this pull request
Dec 18, 2024
…ies#22088) Follow-up of zed-industries#22004 Closes zed-industries#22078 Release Notes: - Fixed splitting terminal items in the center
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20060
Closes #20720
Closes #19873
Closes #9445
Release Notes: