-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Description
Summary
A button that looks like it's meant to always allow a specific tool puts "always_allow_tool_actions": true
in your config, allowing every tool to be used without confirmation.
Description
Steps to trigger the problem:
- Install the "Context7 MCP Server" extension.
- Delete the
agent
section in your zed config if you have one and save the config. - Ask
Claude 3.7 Sonnet
from theZed
provider to look up the id of something using the resolve-library-id tool added by the extension. If it makes a difference I observe the behavior during the pro trial period. - When asked if you want to allow the tool, press what appears to be a button to always allow this tool, since this is a rather safe tool that shouldn't need confirmation.
- Ask it to use another, unrelated tool that should require user confirmation, like
terminal
.
Actual Behavior: It uses the other tool without asking for confirmation.
Expected Behavior: It should ask for confirmation before running the other tool, since you have not always allowed the other tool, only the resolve-library-id
tool.
Additional details
It appears the button in question adds a config option to your config to allow any tool, not just the specific tool. From context it very much appears to be a button that's meant to only allow the specific tool. It's inside a box with the tools name, and next to other button pertaining only to the specific tool.
Either it is meant to be the "always allow this tool" button like it appears to be, in which case the bug is that it puts the wrong config option in your config, or it's meant to be an "always allow any tool" button, in which case the bug is that it's not presented as such.
I got very surprised when the agent started running cargo commands to build and run my project without me having to confirm it first. I didn't even know there was a terminal tool, It's not listed among the tools you can configure when you go to customize a profile, and that was the first time I saw it being used.
Zed Version and System Specs
Zed: v0.185.13 (Zed)
OS: Linux Wayland arch unknown
Memory: 60.4 GiB
Architecture: x86_64
GPU: AMD Radeon RX 5700 XT (RADV NAVI10) || radv || Mesa 25.0.5-arch1.1