[Host.Redis] prevent RedisListCheckerConsumer from crashing on disconnect #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirill Povolotskyy <[email protected]>
zarusz
reviewed
Jul 26, 2025
src/SlimMessageBus.Host.Redis/Consumers/RedisListCheckerConsumer.cs
Outdated
Show resolved
Hide resolved
zarusz
reviewed
Jul 26, 2025
src/SlimMessageBus.Host.Redis/Consumers/RedisListCheckerConsumer.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Kirill Povolotskyy <[email protected]>
Signed-off-by: Kirill Povolotskyy <[email protected]>
Signed-off-by: Kirill Povolotskyy <[email protected]>
Signed-off-by: Kirill Povolotskyy <[email protected]>
|
|
Hi @cyril265, just checking in - are the changes ready now? Everything looks good to me, and I’m happy to approve once you confirm. Let me know! |
|
Hey @zarusz, |
|
Thank you for your first contribution, @cyril265! Your changes will be included in the 3.3.1 milestone, along with a few other updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #419 by catching exceptions
It retries the next queue "automatically" because it's inside the loop.
Draft because I didn't add a test case. Not really sure how to simulate a disconnect and reconnect inside a test.