-
Notifications
You must be signed in to change notification settings - Fork 123
blog: Add PortSwigger lab walkthrough (Broken brute-force protection, IP block) #2976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job, no security vulnerabilities found in this Pull Request |
f7f341e to
1e54b34
Compare
|
Leaving a comment here about force-pushed changes. I added the sign-off trailer. EDIT: @kingthorin I don't remember being prompted to sign the CLA when I created this PR. Do I need to create a PR to the CLA repo? |
|
Nope you're good, CLA isn't enabled for this repo. Thanks for checking though. |
|
@kingthorin I was working through a different lab and realized I got some details in this walkthrough mixed up with details from another lab. I'll correct the inaccuracies and let you know when this is ready for review again. |
|
Thanks for the heads up. I hadn't gone to look at the lab at all, so we easily could have missed that..... |
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
|
Thanks for this! As you've probably noticed we've got another Portswigger lab PR outstanding #2973 so we'll aim to get that one published first and then focus on this one 😁 |
|
This can be rebased now |
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to do a thorough review of the text and details over the next few days.
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
Alright, thank you! |
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
|
To address the DCO requirement you'll need to sign-off the commit(s):
Handle this how you like, but I find it's easiest to collapse all the commits into one and just do the signoff on that one. |
|
@kingthorin I've read through your comments (left replies on some). I'll address them within the next few days. Thanks for being so thorough with your review. Appreciate it! |
|
No problem at all, thanks for tackling this! |
|
@kingthorin I've implemented all feedback from your review. Also fixed the DCO issue (I had the trailer in the previous commits but was modifying it manually and it ended up being invalid). Didn't squash commits because I wanted to keep the history (initial article vs current one). |
| summary: > | ||
| Walkthrough for the PortSwigger lab, "Broken brute-force protection, IP block". | ||
| images: | ||
| - https://www.zaproxy.org/blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/images/image header-key and house models.jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kingthorin I followed the example of the other articles here. Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd suggest using underscores or hyphens in the filename, and reducing the length (it seems overly verbose).
(Here and the file itself obviously 😉)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reducing the length (it seems overly verbose)
Just to be clear, you mean just the filename of the image, yes? Not including the article (that one's long, too)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya just the image
| 7. [Java Interoperability](https://www.graalvm.org/jdk21/reference-manual/js/JavaInteroperability/) | ||
|
|
||
| _Image credit: [Pexels](https://www.pexels.com/photo/real-estate-concept-with-key-and-house-models-31424880/)._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to include some attribution but wasn't sure where to add it. Is this okay?
Oh, and what do you think of the image itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this, and I'm good with the image too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license says that attribution is not required:
https://www.pexels.com/license/
Attribution is not required. Giving credit to the photographer or Pexels is not necessary but always appreciated.
I don't mind the attribution just saying.
|
Assuming that one filename/reference thing is addressed I'm good with this article now. |
|
@kingthorin I've made the filename change. Also squashed a few commits. |
|
Force-pushed change is more squashing. Done now. |
kingthorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@kingthorin My apologies. Missed a couple of spots. |
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
.../blog/2025-02-17-portswigger-lab-walkthrough-broken-brute-force-protection-ip-block/index.md
Outdated
Show resolved
Hide resolved
|
I've updated the date to today and made some minor tweaks to address @thc202's feedback |
bb0f04d to
6582620
Compare
block) Signed-off-by: Simon Bennetts <psiinon@gmail.com>
|
Thank you both! |
|
Thanks @Wryhder and sorry this took so long to get published. |
|
Thanks @Wryhder !! |
|
@thc202 Thanks a bunch for your review. Thanks @psiinon for making the changes. Article looks good, thank you! I'll repost. And thanks again @kingthorin for your help with this. |

@kingthorin I tried to add callouts/admonitions (called alerts in the Hugo docs) like this to match the look in the Notion doc, but it doesn't seem to work:
Can I add a template for alerts as shown in the docs here?