-
-
Notifications
You must be signed in to change notification settings - Fork 736
authhelper: add MS login handling to BBA #6664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New Issues (1)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
3d17fc0
to
ab45753
Compare
...uthhelper/src/main/java/org/zaproxy/addon/authhelper/internal/auth/MsLoginAuthenticator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Microsoft login handling to Browser Based Authentication (BBA) by implementing a dedicated authenticator for Microsoft login flows. The changes introduce a new plugin-style architecture where multiple authenticators can be attempted in sequence.
Key changes:
- Introduces a new
MsLoginAuthenticator
class to handle Microsoft-specific login flows - Refactors existing authentication logic into a
DefaultAuthenticator
- Creates an
Authenticator
interface to support multiple authentication strategies
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
MsLoginAuthenticator.java | New authenticator implementation for Microsoft login flows with state machine logic |
DefaultAuthenticator.java | Extracted existing authentication logic into a dedicated authenticator class |
Authenticator.java | New interface defining the contract for authentication implementations |
AuthUtils.java | Refactored to use authenticator chain pattern and made helper methods public |
Messages.properties | Added diagnostic message keys for Microsoft login steps |
CHANGELOG.md | Documented the new Microsoft login support feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...uthhelper/src/main/java/org/zaproxy/addon/authhelper/internal/auth/MsLoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...uthhelper/src/main/java/org/zaproxy/addon/authhelper/internal/auth/MsLoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...uthhelper/src/main/java/org/zaproxy/addon/authhelper/internal/auth/MsLoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...uthhelper/src/main/java/org/zaproxy/addon/authhelper/internal/auth/MsLoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...uthhelper/src/main/java/org/zaproxy/addon/authhelper/internal/auth/MsLoginAuthenticator.java
Outdated
Show resolved
Hide resolved
...uthhelper/src/main/java/org/zaproxy/addon/authhelper/internal/auth/MsLoginAuthenticator.java
Show resolved
Hide resolved
ab45753
to
5cee12c
Compare
Handle MS login through BBA. Signed-off-by: thc202 <[email protected]>
5cee12c
to
ff33300
Compare
Handle MS login through BBA.