Skip to content

Conversation

tkrop
Copy link
Member

@tkrop tkrop commented Apr 18, 2023

Creates a new rule to require JSON-payload to be sanitized.

fixes #734.

@ePaul
Copy link
Member

ePaul commented Apr 18, 2023

👍

Copy link
Member

@tfrauenstein tfrauenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx a lot for the PR! I provided some change proposals

@tkrop tkrop force-pushed the sanitize-json-payload branch from ffc5b5c to 8536c98 Compare April 20, 2023 16:22
@tkrop tkrop force-pushed the sanitize-json-payload branch from 8536c98 to 789e45f Compare April 21, 2023 07:13
@tfrauenstein
Copy link
Member

👍

@ePaul
Copy link
Member

ePaul commented May 2, 2023

Discussed in the meeting:

  • keep the rule as-is right now.
  • discuss with Nakadi team on whether it makes sense to validate this on Nakadi side.
  • discuss with Skipper people on whether a filter for JSON makes sense there

@tkrop
Copy link
Member Author

tkrop commented May 12, 2023

👍

1 similar comment
@ePaul
Copy link
Member

ePaul commented May 12, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn about downstream failures of JSON \u0000 encoding

3 participants