expose helpful attributes so users can perform lookaheads with respect to @skip / @include directives #269
+2,943
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an experimental feature flag to enable fieldAvailability and isFieldRequested on GraphQLResolveInfo, allowing resolvers to detect which fields are requested after skip/include directives are applied. Includes a comprehensive test suite for various directive scenarios. Fragment support is limited in this initial implementation.
trkohler
changed the title
generation - Add comprehensive unit tests for createFieldAvailability and generateFieldAvailabilityCode, including handling of directives, path-based conditions, and error cases - Add integration tests for complex GraphQL queries with nested objects, aliases, lists, and conditional fields - Ensure tests verify parent-child separation and correct field availability for each resolver - Document fragment support limitations in tests and verify fallback behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define 2 new attributes in resolver info argument:
available under feature flag
enableFieldAvailabilitythis should enable more efficient & informant lookaheads because based on the availability, resolver logic can be simplified and unnecessary calls avoided.
the information is available only for immediate children fields.
if the alias is used for a field, in
fieldAvailabilitythe field is available under it's real name