WithUnknownTypeResolution breaks Constructor selection rules

[schuettecarsten]

I have a class that implements these two constructors:

public LoggerFactory(IEnumerable<ILoggerProvider> providers, LoggerFilterOptions filterOptions)
public LoggerFactory(IEnumerable<ILoggerProvider> providers, IOptionsMonitor<LoggerFilterOptions> filterOption)

Given there is a service registration for IEnumerable<ILoggerProvider> and for IOptionsMonitor<LoggerFilterOptions>, but no registration for LoggerFilterOptions. If the container is configured without WithUnknownTypeResolution, everything works fine, the second constructor is selected. But if WithUnknownTypeResolution is used, then the first constructor is choosed, regardless whether the second constructor is fully resolvable or not.

I would expect that unknown type resolution only runs if no constructor matches completely.

[z4kn4fein]

Thank you for pointing this out! Yes, when the container iterates over the constructors in order, it tries everything to make one of them work, which means when the WithUnknownTypeResolution is enabled, it checks the non resolvable arguments of the actual constructor also, even when there is a fully resolvable one ahead in the collection.

I agree that your expectation has more sense than the current selection strategy, so i'll make a fix on this soon and publish it with the next release.

[z4kn4fein]

Pushed a new version with the fix to my pre-release nuget feed, could you please also check that it works as expected? Thanks!

[schuettecarsten]

Tested the preview version, looks good! 👍

[z4kn4fein]

released in v2.7.3