Fix issue #1738: [datatable-sort] Sort order inconsistent when comparing on equal value #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing on equal value
|
CLA is valid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request address issue #1738, where datatable sorting on equal values does not always return the same result. The issue is especially important in paginated tables, where inconsistent sorting could leave out rows when moving from page to page, or what could be seen as missing data. Check the issue for jsbin examples.
As a tiebreaker in the event that values are equal sorting is based on the insertion order, determined by parsing the model's clientId.
Included in this PR are unit tests, inline comments, and a small spelling correction in the docs.