[DB-18017] Completed the implementation of TraverseAndExtractDefNames… #2992
+173
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FromDefElem to fetch the defNames values for other scenarios where the arg is not string
sanyamsinghal
requested review from
makalaaneesh and
priyanshi-yb
and removed request for
makalaaneesh
sanyamsinghal
commented
Aug 25, 2025
| options:{def_elem:{defname:"security_barrier" arg:{string:{sval:"false"}} defaction:DEFELEM_UNSPEC location:57}} | ||
| Extract all defnames from the def_eleme node | ||
| */ | ||
| func ProtoAsAIndirectionNode(msg protoreflect.Message) (*pg_query.A_Indirection, bool) { |
There was a problem hiding this comment.
just function rename
| if tc := arg.GetTypeCast(); tc != nil { | ||
| return NormalizeDefElemArgToString(tc.Arg) | ||
| } | ||
| return arg.String() |
There was a problem hiding this comment.
This isn't a complete normalization, right?
As there could be other arg types like expression, function call
There was a problem hiding this comment.
Are there any other known cases for def elements?
I added what i could find/think of.
There was a problem hiding this comment.
added log line for fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…FromDefElem to fetch the defNames values for other scenarios where the arg is not string
Describe the changes in this pull request
Describe if there are any user-facing changes
NA
How was this pull request tested?
Added unit tests.
Does your PR have changes in callhome/yugabyted payloads? If so, is the payload version incremented?
Does your PR have changes that can cause upgrade issues?