Potential fix for pg/indexes test intermittent failure. #2624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ SELECT | |||
| md5(random()::text), | |||
| md5(random()::text) | |||
| from ( | |||
| SELECT * FROM generate_series(1,100000) AS id | |||
| SELECT * FROM generate_series(1,1000) AS id | |||
There was a problem hiding this comment.
- reasoning behind this?
- How are you going to verify this fixes the issue? run it multiple times?
This reverts commit b2993b9.
Comment on lines
+145
to
+148
| - name: "copy and zip logs" | ||
| if: ${{ !cancelled() && matrix.test_group == 'offline' }} | ||
| run: | | ||
| docker exec yugabytedb bin/yugabyted collect_logs --stdout > yugabyted-logs-${{ matrix.test_group }}-${{ matrix.version }}-${{ matrix.BETA_FAST_DATA_EXPORT }}.tar.gz |
There was a problem hiding this comment.
it will be good to keep this code as commented for future.
sanyamsinghal
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Describe if there are any user-facing changes
How was this pull request tested?
Does your PR have changes in callhome/yugabyted payloads? If so, is the payload version incremented?
Does your PR have changes that can cause upgrade issues?