Skip to content

[CLOUDGA-24903] [Terraform] Increase timeout for enable/disable conne… #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
Merged

[CLOUDGA-24903] [Terraform] Increase timeout for enable/disable conne… #173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0676de1
[CLOUDGA-24903] [Terraform] Increase timeout for enable/disable conne…
NiyatiSinha-yb Aug 22, 2025
61105a3
Merge branch 'main' into CLOUDGA-24903
NiyatiSinha-yb Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions managed/resource_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,7 +1512,7 @@ func pauseCluster(ctx context.Context, apiClient *openapiclient.APIClient, accou

}

func enableConnectionPooling(ctx context.Context, apiClient *openapiclient.APIClient, accountId string, projectId string, clusterId string) (err error) {
func enableConnectionPooling(ctx context.Context, apiClient *openapiclient.APIClient, accountId string, projectId string, clusterId string, numNodes int) (err error) {
connectionPoolingOpSpec := openapiclient.NewConnectionPoolingOpSpec(openapiclient.CONNECTIONPOOLINGOPENUM_ENABLE)
response, err := apiClient.ClusterApi.PerformConnectionPoolingOperation(ctx, accountId, projectId, clusterId).ConnectionPoolingOpSpec(*connectionPoolingOpSpec).Execute()

Expand All @@ -1528,7 +1528,9 @@ func enableConnectionPooling(ctx context.Context, apiClient *openapiclient.APICl
// read status, wait for status to be done
readClusterRetries := 0
retryPolicy := retry.NewConstant(10 * time.Second)
retryPolicy = retry.WithMaxDuration(1200*time.Second, retryPolicy)
// Calculate timeout based on number of nodes: 15 minutes per node
timeout := time.Duration(15*numNodes) * time.Minute
retryPolicy = retry.WithMaxDuration(timeout, retryPolicy)
err = retry.Do(ctx, retryPolicy, func(ctx context.Context) error {
clusterState, readInfoOK, message := getClusterState(ctx, accountId, projectId, clusterId, apiClient)
if readInfoOK {
Expand All @@ -1548,7 +1550,7 @@ func enableConnectionPooling(ctx context.Context, apiClient *openapiclient.APICl
return nil
}

func disableConnectionPooling(ctx context.Context, apiClient *openapiclient.APIClient, accountId string, projectId string, clusterId string) (err error) {
func disableConnectionPooling(ctx context.Context, apiClient *openapiclient.APIClient, accountId string, projectId string, clusterId string, numNodes int) (err error) {
connectionPoolingOpSpec := openapiclient.NewConnectionPoolingOpSpec(openapiclient.CONNECTIONPOOLINGOPENUM_DISABLE)
response, err := apiClient.ClusterApi.PerformConnectionPoolingOperation(ctx, accountId, projectId, clusterId).ConnectionPoolingOpSpec(*connectionPoolingOpSpec).Execute()

Expand All @@ -1564,7 +1566,9 @@ func disableConnectionPooling(ctx context.Context, apiClient *openapiclient.APIC
// read status, wait for status to be done
readClusterRetries := 0
retryPolicy := retry.NewConstant(10 * time.Second)
retryPolicy = retry.WithMaxDuration(1200*time.Second, retryPolicy)
// Calculate timeout based on number of nodes: 15 minutes per node
timeout := time.Duration(15*numNodes) * time.Minute
retryPolicy = retry.WithMaxDuration(timeout, retryPolicy)
err = retry.Do(ctx, retryPolicy, func(ctx context.Context) error {
clusterState, readInfoOK, message := getClusterState(ctx, accountId, projectId, clusterId, apiClient)
if readInfoOK {
Expand Down Expand Up @@ -2184,11 +2188,17 @@ func (r resourceCluster) Update(ctx context.Context, req tfsdk.UpdateResourceReq
}
}

// Calculate total number of nodes across all regions for connection pooling timeout
totalNodes := 0
for _, regionInfo := range plan.ClusterRegionInfo {
totalNodes += int(regionInfo.NumNodes.Value)
}

// Disable Connection Pooling if the desired state is set to 'Disabled' and it is enabled currently
if fflags.IsFeatureFlagEnabled(fflags.CONNECTION_POOLING) && !state.DesiredConnectionPoolingState.Unknown && strings.EqualFold(state.DesiredConnectionPoolingState.Value, "Enabled") && (plan.DesiredConnectionPoolingState.Unknown || strings.EqualFold(plan.DesiredConnectionPoolingState.Value, "Disabled")) {
// Disable Connection Pooling
tflog.Info(ctx, fmt.Sprintf("Existing Desired Connection Pooling State in State is %v", state.DesiredConnectionPoolingState.Value))
err := disableConnectionPooling(ctx, apiClient, accountId, projectId, clusterId)
err := disableConnectionPooling(ctx, apiClient, accountId, projectId, clusterId, totalNodes)
if err != nil {
resp.Diagnostics.AddError("Disable connection pooling failed: ", err.Error())
return
Expand Down Expand Up @@ -2462,7 +2472,7 @@ func (r resourceCluster) Update(ctx context.Context, req tfsdk.UpdateResourceReq

// Enable connection pooling if the desired state is set to 'Enabled'
if fflags.IsFeatureFlagEnabled(fflags.CONNECTION_POOLING) && !plan.DesiredConnectionPoolingState.Unknown && strings.EqualFold(plan.DesiredConnectionPoolingState.Value, "Enabled") {
err := enableConnectionPooling(ctx, apiClient, accountId, projectId, clusterId)
err := enableConnectionPooling(ctx, apiClient, accountId, projectId, clusterId, totalNodes)
if err != nil {
resp.Diagnostics.AddError("Enabling connection pooling Failed: ", err.Error())
}
Expand Down