Skip to content

Conversation

tansy
Copy link

@tansy tansy commented Dec 16, 2024

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [x ] I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • [x ] Improvement
  • [x ] New extractor
  • New feature

Description of your pull request and other information

Add `streamable/t/' url support. It is analogous to youtube/embed.

Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, but you should add a test for the changed URL pattern, which you promised to do in the PR checklist IIRC.

If you use one of the existing test videos, it can just be an only_matching test:

        {
            'url': 'https://streamable.com/t/dnd1',
            'only_matching': True,
        }

@tansy
Copy link
Author

tansy commented Jan 29, 2025

I did test it before pushing, just didn't get thoroughly what you meant by 'test'.

I hope that's what you mean. If not, I don't know.

BTW, this video
doesn't work any more.

@tansy tansy requested a review from dirkf February 12, 2025 16:53
@MahmoudMabrok
Copy link

MahmoudMabrok commented Jun 10, 2025

@tansy tests, mean to add a code to test the new code added, there are (unit testing, integration testing).

This is example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants