Skip to content

Statusbar height calculation using a better api #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Statusbar height calculation using a better api #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7514254
Statusbar height calculation using position on screen
anoop44 Feb 25, 2020
f97fe81
Merge https://github.com/yshrsmz/KeyboardVisibilityEvent
anoop44 Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions ...nt/src/main/java/net/yslibrary/android/keyboardvisibilityevent/KeyboardVisibilityEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,11 @@ object KeyboardVisibilityEvent {

val layoutListener = object : ViewTreeObserver.OnGlobalLayoutListener {

private val r = Rect()

private var wasOpened = false

override fun onGlobalLayout() {
activityRoot.getWindowVisibleDisplayFrame(r)

val screenHeight = activityRoot.rootView.height
val heightDiff = screenHeight - r.height()

val isOpen = heightDiff > screenHeight * KEYBOARD_MIN_HEIGHT_RATIO
val isOpen = isKeyboardVisible(activity)

if (isOpen == wasOpened) {
// keyboard state has not changed
Expand Down Expand Up @@ -140,8 +134,11 @@ object KeyboardVisibilityEvent {

activityRoot.getWindowVisibleDisplayFrame(r)

val location = IntArray(2)
getContentRoot(activity).getLocationOnScreen(location)

val screenHeight = activityRoot.rootView.height
val heightDiff = screenHeight - r.height() - getContentRoot(activity).top
val heightDiff = screenHeight - r.height() - location[1]

return heightDiff > screenHeight * KEYBOARD_MIN_HEIGHT_RATIO
}
Expand Down