Skip to content

Adds discover feature with organizations listing #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

natannobre
Copy link
Collaborator

  • Introduced CardComponent for displaying organizations with images and actions.
  • Added discoverable scope to the Organization model for filtering based on privacy settings.

This PR implements Step 3 described on issue #226.

@natannobre natannobre requested a review from yshmarov May 3, 2025 18:27
@natannobre natannobre self-assigned this May 3, 2025
@natannobre natannobre linked an issue May 3, 2025 that may be closed by this pull request
Copy link
Owner

@yshmarov yshmarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to implement "Join" & "Request to join" separately?

I think with "You are already a member of this organization." we can have a button "Open"

@natannobre
Copy link
Collaborator Author

Do you want to implement "Join" & "Request to join" separately?

That was the original plan, but I don't mind to continue working in the branch if you prefer.

@natannobre
Copy link
Collaborator Author

I think with "You are already a member of this organization." we can have a button "Open"

I thought about doing that, but since the organization buttons are so easily accessed I figured the text would be enough, but I'll make this change.

- Introduced CardComponent for displaying organizations with images and actions.
- Added discoverable scope to the Organization model for filtering based on privacy settings.
@natannobre natannobre force-pushed the add-discover-organizations branch from b33341a to ac355da Compare May 5, 2025 11:13
@natannobre natannobre requested a review from yshmarov May 5, 2025 11:15
Comment on lines +28 to +30
assert_includes response.body, organization1.name
assert_includes response.body, organization2.name
assert_not_includes response.body, organization3.name
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Owner

@yshmarov yshmarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the text does not matter too much now - we can improve it later;

looks good now
Screenshot 2025-05-05 at 17 48 03

you can make the buttons work in the next step

@natannobre natannobre merged commit ccd1d3c into main May 6, 2025
4 of 5 checks passed
@natannobre natannobre deleted the add-discover-organizations branch May 6, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization privacy settings
2 participants