Skip to content

Add Organization Privacy Settings Management #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

natannobre
Copy link
Collaborator

  • Added Organizations::InvitationsController for managing user invitations.
  • Introduced Organizations::RequestsToJoinController for handling requests to join.
  • Enhanced organization show view with access settings for privacy and invitations.

These changes implements Step 2 commented in this issue #226.

@natannobre natannobre linked an issue May 1, 2025 that may be closed by this pull request
@natannobre natannobre self-assigned this May 1, 2025
@natannobre natannobre requested review from yshmarov and removed request for yshmarov May 1, 2025 20:34
@natannobre natannobre force-pushed the add-organization-privacy-settings branch 2 times, most recently from a8374b7 to ca85df4 Compare May 2, 2025 04:06
@natannobre
Copy link
Collaborator Author

Hello @yshmarov, I believe that the feature for this PR is implemented as described in Step 2 (#226).

Next step is test the new files and make the CI's tests pass. You can review while I implement tests.

@natannobre natannobre requested a review from yshmarov May 2, 2025 04:11
Copy link
Owner

@yshmarov yshmarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
Screenshot 2025-05-02 at 10 42 18

I would maybe keep access settings in Teammates
Screenshot 2025-05-02 at 10 45 24

Copy link
Owner

@yshmarov yshmarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get it all in to see the big picture

- Updated organization_params to include privacy_setting.
- Added Organizations::InvitationsController for managing user invitations.
- Introduced Organizations::RequestsToJoinController for handling requests to join.
- Enhanced organization show view with access settings for privacy and invitations.

These changes implements Step 2 commented in this issue #226
@natannobre natannobre force-pushed the add-organization-privacy-settings branch from ca85df4 to 8a6b12f Compare May 3, 2025 12:33
@natannobre natannobre marked this pull request as ready for review May 3, 2025 12:35
@natannobre natannobre merged commit 6870490 into main May 3, 2025
4 of 5 checks passed
@natannobre natannobre deleted the add-organization-privacy-settings branch May 3, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization privacy settings
2 participants