Skip to content

fix(checkbox): apply 'checked-color' when 'checkbox' is indeterminate #13553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2025

Conversation

keeplearning66
Copy link
Contributor

@keeplearning66 keeplearning66 commented Jul 11, 2025

This PR is to fix #13552

The selected state color and indeterminate state color of a group of checkboxes could be better if kept consistent, as this would create a more unified style

Set 'checked-color' to 'red',comparison of effects:

Before modification
{9A76EC29-8476-4C7E-B6B3-5B916C320F62}

After modification
{B688C328-D739-47D7-B5D1-0FF7A86E8ABF}

I didn't see any unit tests related to the color, so I didn't add the corresponding unit tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (ec5b45b) to head (c669235).
Report is 122 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13553      +/-   ##
==========================================
+ Coverage   89.60%   89.73%   +0.12%     
==========================================
  Files         257      257              
  Lines        7013     7043      +30     
  Branches     1736     1743       +7     
==========================================
+ Hits         6284     6320      +36     
+ Misses        384      383       -1     
+ Partials      345      340       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keeplearning66
Copy link
Contributor Author

keeplearning66 commented Jul 11, 2025

Although the literal meaning of 'checked-color' is the color for the checked state, if this property is not applied to the indeterminate state, the indeterminate state will have no color property set, which may lead to inconsistent styling.
For example, the following situation
{C9C3DC10-008A-415D-94ED-CB3F02FEBFC0}

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan enabled auto-merge (squash) July 12, 2025 07:44
@chenjiahan chenjiahan merged commit ae466fc into youzan:main Jul 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkbox设置自定义颜色后不确定状态下颜色不生效
3 participants