Skip to content

docs: fix typo in uploader document #13502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Conversation

Uyoahz26
Copy link
Contributor

This pull request includes a minor correction to the documentation for the before-delete hook in the Uploader component. The change clarifies that returning false stops the deletion of the file, rather than stopping the reading of the file.

Documentation updates:

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (ec5b45b) to head (3c2e4e6).
Report is 101 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13502      +/-   ##
==========================================
+ Coverage   89.60%   89.74%   +0.14%     
==========================================
  Files         257      257              
  Lines        7013     7033      +20     
  Branches     1736     1741       +5     
==========================================
+ Hits         6284     6312      +28     
+ Misses        384      379       -5     
+ Partials      345      342       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@chenjiahan chenjiahan merged commit b68dcca into youzan:main Jun 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants