Skip to content

feat(FloatingBubble): allow gap xy to be set separately (#13297) #13429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2025

Conversation

ALiangLiang
Copy link
Contributor

期望如標題所述,這樣我就能貼近側邊設定離底部多高。

兼容 number 同時,新增 { x: number, y: number } 類型,採用此類型而不是數組的原因是與 v-model:offset 同類型較統一。

close #13297

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (ec5b45b) to head (9b8655d).
Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13429      +/-   ##
==========================================
+ Coverage   89.60%   89.69%   +0.09%     
==========================================
  Files         257      257              
  Lines        7013     7026      +13     
  Branches     1736     1739       +3     
==========================================
+ Hits         6284     6302      +18     
+ Misses        384      380       -4     
+ Partials      345      344       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ALiangLiang ALiangLiang force-pushed the feat/floating-bubble-gaps branch from cf8ca4d to 33a320b Compare April 8, 2025 03:41
@ALiangLiang ALiangLiang changed the title FloatingBubble 元件的 gap 容許 xy 分開設定 feat(FloatingBubble): gap 容許 xy 分開設定 Apr 11, 2025
@ALiangLiang ALiangLiang changed the title feat(FloatingBubble): gap 容許 xy 分開設定 feat(FloatingBubble): gap 容許 xy 分開設定 (#13297) Apr 11, 2025
@chenjiahan chenjiahan changed the title feat(FloatingBubble): gap 容許 xy 分開設定 (#13297) feat(FloatingBubble): allow gap xy to be set separately (#13297) Apr 13, 2025
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@chenjiahan chenjiahan merged commit d739f67 into youzan:main Apr 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FloatingBubble 组件的gap希望可以兼容数组形式
3 participants