add a system call mock for uid/gid. #3173
Merged
+132
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nayuta-ai <[email protected]>
utam0k
added
the
kind/cleanup
utam0k
reviewed
May 27, 2025
| gid: Gid, | ||
| euid: Uid, | ||
| egid: Gid, | ||
| // TODO: add more fields such as suid, sgid, etc. |
There was a problem hiding this comment.
I don't think we will need to add these IDs. Why did you think we needed them?
There was a problem hiding this comment.
The set_id function sets uid/euid/suid and gid/egid/sgid, so I initially thought we might need these fields in the future. However, since there’s currently no implementation for get_suid or get_sgid on nix, they aren't necessary at this point. I'll remove them, thanks!
Signed-off-by: nayuta-ai <[email protected]>
|
!github easy-benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a system call mock for uid, gid. euid, egid, etc.
Type of Change
Testing
Related Issues
Fixes #3136
Additional Context
This change is related to the issue discussed in this comment.
I have moved the
getoperations foruid,gid,euid, andegidused in thelibcontainerandyoukicrates into thesyscallpackage. As forlibcgroupandruntimetest, they are not dependent onlibcontainer, so they are omitted.