Fix test_canonicalize_rootfs #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepancheg
force-pushed
the
pr280
branch
2 times, most recently
from
7782d17 to
d12a4d2
Compare
|
I don't know why DCO complains: 
|
utam0k
reviewed
Apr 30, 2025
| @@ -277,7 +277,8 @@ mod tests { | |||
| fn test_canonicalize_rootfs() { | |||
| let rootfs_name = "rootfs"; | |||
| let bundle = tempfile::tempdir().expect("failed to create tmp test bundle dir"); | |||
| let rootfs_absolute_path = bundle.path().join(rootfs_name); | |||
| let bundle = fs::canonicalize(bundle.path()).expect("failed to canonicalize bundle"); | |||
There was a problem hiding this comment.
I wonder why macOS needs fs::canonicalize().
There was a problem hiding this comment.
$ echo $TMPDIR; realpath $TMPDIR
/var/folders/_h/j_17023n23s3_50cq_gwhrrc0000gq/T/
/private/var/folders/_h/j_17023n23s3_50cq_gwhrrc0000gq/T
There was a problem hiding this comment.
May I ask you to add the comment?
|
Same problem reported in #163. |
Signed-off-by: Stepan Koltsov <[email protected]>
utam0k
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failed on my macOS laptop: