This repository was archived by the owner on May 22, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 456
[BOUNTY] Liquids try #3: Return of the pee #22169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
finally, it is our time |
Contributor
|
im gonna pee so hard |
Contributor
|
one step closer to ocean station inshallah |
Contributor
|
there better be jarate gameplay |
Yogbot-13
added a commit
that referenced
this pull request
Jun 4, 2024
Yogbot-13
added a commit
that referenced
this pull request
Jun 4, 2024
Yogbot-13
added a commit
that referenced
this pull request
Jun 4, 2024
Contributor
|
Is there any way to tell a difference between a liquid and gas at a glance? They both just seem to be translucent overlays |
Yogbot-13
added a commit
that referenced
this pull request
Jun 4, 2024
Contributor
its pretty obvious |
Contributor
Yogbot-13
added a commit
that referenced
this pull request
Jun 4, 2024
Contributor
Yogbot-13
added a commit
that referenced
this pull request
Jun 4, 2024
Yogbot-13
added a commit
that referenced
this pull request
Jul 26, 2024
Closed
Yogbot-13
added a commit
that referenced
this pull request
Jul 28, 2024
Yogbot-13
added a commit
that referenced
this pull request
Aug 1, 2024
Yogbot-13
added a commit
that referenced
this pull request
Aug 2, 2024
Yogbot-13
added a commit
that referenced
this pull request
Aug 3, 2024
Yogbot-13
added a commit
that referenced
this pull request
Aug 6, 2024
Yogbot-13
added a commit
that referenced
this pull request
Aug 6, 2024
Yogbot-13
added a commit
that referenced
this pull request
Aug 6, 2024
Moltijoe
suggested changes
Aug 7, 2024
Moltijoe
approved these changes
Aug 7, 2024
Contributor
Moltijoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine, i guess it's alright, i can make those tweaks in a different pr
nothing fundamentally flawed with the pr
Moltijoe
approved these changes
Aug 7, 2024
Yogbot-13
added a commit
that referenced
this pull request
Aug 7, 2024
JamieD1
approved these changes
Aug 7, 2024
Contributor
JamieD1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Admin
This PR affects administrators
DME Edit
This PR affects the yogstation.DME file
DO NOT MERGE
Should not be merged without express approval from a Head Dev
Feature
This adds new content to the game
Literally the best PR
My god its beautiful
Sprites
This PR has spriting changes
Test Merge - Requested
This PR is waiting for a test merge to be scheduled
Test Merge - Scheduled
This PR is waiting to be test merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Document the changes in your pull request
Ports some of Monkestation/Monkestation2.0@8bbcd47
Ports Monkestation/Monkestation2.0#2072
Ports tgstation/tgstation#71430
fulfills https://forums.yogstation.net/threads/300-liquid-simulation-tgcode-edition-ss13-server.27154/
Adds liquids from Monkestation. Adds some basic ocean turfs.
Things this does have:
Liquids
Interaction with liquids
Admin ability to add/remove liquids
Drains?
Things this does not have:
TG plumbing (further PR)
Ocean generation (further PR)
Why is this good for the game?
More stuff to do and interact with = more fun
Testing
Wiki Documentation
will fill out
Changelog
🆑
rscadd: adds liquids
/:cl: