Replaces intents with combat mode

[SapphicOverload]

Document the changes in your pull request

This removes intents and replaces them with combat mode and alternate right-click action. Default keybinds are 4 to enable combat mode and 1 to disable, same as previous harm/help intents.

Major changes:

• Removes disarm and grab intent, help/harm intents are now combat mode off/on
• Right-click menu moved to shift + right-click
• Right click is now disarm, grabbing is still ctrl-click, both are possible with or without combat mode enabled
• Default movement lock key is now alt, to allow grabbing while moving (this does not change existing save files)
• Some martial arts have been reworked, in-game instructions have been updated to reflect changes

Interaction changes:

• Right click to deconstruct tables/racks/walls/etc, and to open the wire panel of autolathes
• Right click to harm when using a baton or bo staff
• Right click to unlock APCs and air alarms, alt-click to discharge energy into them as an ethereal or recharge as a preternis.
• Right click to malpractice surgery
• Right click to hold people at gunpoint
• Right click to use PDA while in ID slot
• Right click to open a storage item (on top of alt click)
• Right click to fire kinetic crusher projectile, left click can now cleave attack with combat mode on
• Right click to toggle pumps and other atmospherics machines

Plus more that I likely forgot about. In general if something used to be done with disarm or grab intent, it's probably done with right-click or ctrl-click now.

Original PR here: tgstation/tgstation#56601

Why is this good for the game?

After having been on other servers that use the combat mode system, it's difficult to go back to using intents because of how clunky and unintuitive they feel compared to it.

To anyone who's already used to it and don't know anything else, intents might seem intuitive on the surface in a "what do you want to do with your click" sort of way, but this goes out the window when clicking on anything that isn't another player where "disarm" and "grab" don't make much sense, like when deconstructing a table.

As the original PR puts it:

"Intents heavily cripple both the code and the UI design of interactions. While I understand that a lot of people will dislike this PR as they are used to intents, they are one of our weakest links in terms of explaining to players how to do specific things, and require a lot more keypresses to do compared to this.

As an example, martial arts can now be done without having to juggle 1 2 3 and 4 to switch intents quickly.

The full intention of this shift in control scheme is that right click will become 'secondary interaction' for items, which prevents some of the awkward juggling we have now with item modes etcetera."

Testing

It's like 300+ files changed, no way I can test every single thing I've touched, but everything I've tested so far does work.

Buster arm demonstration:

buster_arm_vs_lizar.mp4

Spriting

Changelog

🆑 Qustinnus, SapphicOverload, Molti
experimental: Replaced intents with combat mode
imageadd: Adds combat mode buttons to the UI, replacing intents
bugfix: Fixes some of the martial arts not working sometimes
/:cl:

[warface1234455]

combat off icon button is invisible

[Addust]

i am neutral on this, but PLEASE give people the option to use intents

[Therandomhoboo]

Yes please for the love of god, i dont care if im banned this is just QoL

[SapphicOverload]

combat off icon button is invisible

Should be fixed now

[Cartlord]

please do not do this

[cuackles]

deleting this was intended or accident ?