Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@Moltijoe
Copy link
Contributor

@Moltijoe Moltijoe commented Apr 7, 2024

Current culprit is this proc call
it calls it just before the return statement
it asks 3 people to respond to a tgui prompt, but without a timeout it can just never end
meaning setup() never finishes returning, and that fire() call never finishes

it was also added by the ai rework pr
the last time we encountered this problem was last time the pr was testmerged

Testing

lol, lmao, good fuckin luck confirming or denying it

🆑
bugfix: fixes the server not restarting at the end of a round
/:cl:

@Moltijoe Moltijoe requested a review from a team as a code owner April 7, 2024 07:34
@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Apr 7, 2024
Yogbot-13 added a commit that referenced this pull request Apr 7, 2024
Yogbot-13 added a commit that referenced this pull request Apr 7, 2024
Yogbot-13 added a commit that referenced this pull request Apr 7, 2024
@warface1234455
Copy link
Contributor

What does this proc even do anyway

@Moltijoe
Copy link
Contributor Author

Moltijoe commented Apr 8, 2024

What does this proc even do anyway

ask bibby, i tried removing it and they insisted it was important

Yogbot-13 added a commit that referenced this pull request Apr 8, 2024
Yogbot-13 added a commit that referenced this pull request Apr 9, 2024
@Moltijoe Moltijoe changed the title Possibly fixes the server not restarting at the end of a round Fixes the server not restarting at the end of a round Apr 9, 2024
@ToasterBiome ToasterBiome merged commit b31d13f into yogstation13:master Apr 9, 2024
Yogbot-13 added a commit that referenced this pull request Apr 9, 2024
@Moltijoe Moltijoe deleted the MaybeFixesServerNotEnding branch April 9, 2024 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants