This repository was archived by the owner on May 22, 2025. It is now read-only.
Fixes invisible carpets and clockwork grilles #21687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silly man forgot base icon states
ToasterBiome
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Slot machines were just fixed, so this fully closes #21533
What was wrong with the carpets?
Only the invincible ones had this issue, they didn't have a base_icon_state set so the smoothing system, upon running the code, would promptly sunder them into nullspace.
Cog grilles?
Normal grilles use smoothing and they're a subtype of those. These ones do not use smoothing however, so the code panicked and didn't know what to do with em.
Testing
Changelog
🆑
bugfix: Fixed invincible carpets looking like a black void (see goat king's arena)
bugfix: Fixed cog grilles looking like smiling tables
/:cl: