Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@ynot01
Copy link
Contributor

@ynot01 ynot01 commented Nov 26, 2023

Document the changes in your pull request

At present, there are 12 voices:

  • 5 female British
  • 1 male British
  • 3 female American
  • 3 male American

There are several filters that get applied in different ways. Robots and machines will have a silicon filter applied. Lizards, aliens, and ethereals have filters attached to their tongues. Gas masks and sechailers have their own filters as well. Radio will sound more radioy than talking to someone in person.

Once I figure out model training (after this is merged preferably) we can start adding user-provided voices and maybe species-specific voices.

Backend info at https://github.com/yogstation13/yogs-tts

  • Do the tgui for the hear-tts pref and voice choice pref
  • Move the 750+ binary files to a containerized backend with build process instead of this repo
  • Testmerge
  • Solve lag if there is any
  • Add pitch preference

Why is this good for the game?

Muh immersion

Testing

tts_uhoh.mp4
tts_cat_poly.mp4

Changelog

🆑
rscadd: Added TTS
/:cl:

@ynot01 ynot01 added the DO NOT MERGE Should not be merged without express approval from a Head Dev label Nov 26, 2023
@ynot01 ynot01 requested a review from a team as a code owner November 26, 2023 02:41
@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label Nov 26, 2023
@iloveloopers
Copy link
Contributor

Remove british voice

@Yarinoi
Copy link
Contributor

Yarinoi commented Nov 26, 2023

please have this be an option you can disable i dont want this

@azzzertyy
Copy link
Contributor

please have this be an option you can disable i dont want this

image

@Yarinoi
Copy link
Contributor

Yarinoi commented Nov 26, 2023

please have this be an option you can disable i dont want this

image

thank god

@Scrambledeggs00
Copy link
Contributor

Aeiou
John Madden

@warface1234455
Copy link
Contributor

fucking goated

@00ze-cyclone
Copy link
Contributor

00ze-cyclone commented Nov 26, 2023

TTS sound flat and emotionless which is bad for immersion.
When you see the text you can imagine the voice in your head and the intonation, with TTS you now have that noise that get linked to what you read that’s completely dissonant.
Also the issue that typos make things sounds weird, with just texts your brain can just correct the typos and you don’t notice it, with sounds even if your brain correct the meaning you still heard something nonsensical and out of place.

@neeshacark
Copy link
Contributor

TTS sound flat and emotionless which is bad for immersion. When you see the text you can imagine the voice in your head and the intonation, with TTS you now have that noise that get linked to what you read that’s completely dissonant. Also the issue that typos make things sounds weird, with just texts your brain can just correct the typos and you don’t notice it, with sounds even if your brain correct the meaning you still heard something nonsensical and out of place.

just turn it off if it bothers y ou

@azzzertyy
Copy link
Contributor

just turn it off if it bothers y ou

sorry yogstation players don't understand stand the concept of "optional"

@RG4ORDR
Copy link
Contributor

RG4ORDR commented Nov 27, 2023

WHOO TOOK DAE DAM ARDSOOTS

@github-actions github-actions bot added the Config Config files need to be changed on the host for this to work label Nov 27, 2023
@00ze-cyclone
Copy link
Contributor

TTS sound flat and emotionless which is bad for immersion. When you see the text you can imagine the voice in your head and the intonation, with TTS you now have that noise that get linked to what you read that’s completely dissonant. Also the issue that typos make things sounds weird, with just texts your brain can just correct the typos and you don’t notice it, with sounds even if your brain correct the meaning you still heard something nonsensical and out of place.

just turn it off if it bothers y ou

Just because it’s optional doesn’t mean it’s completely free of criticism, mood is optional and I can still say it fucking suck.

@github-actions github-actions bot added the tgui This PR affects TGUI label Nov 27, 2023
@MajManatee

This comment has been minimized.

Copy link
Contributor

@ToasterBiome ToasterBiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a config option and handling to automatically disable it over a certain population. Preferably a min/max like we have the 1.1 tick highpop so if we're sitting at the number it doesn't keep flipping on and off.

@ynot01 ynot01 added TESTMERGED This PR is currently live in a test merge. Test Merge - Scheduled This PR is waiting to be test merged labels Nov 30, 2023
@ynot01 ynot01 mentioned this pull request Nov 30, 2023
28 tasks
@ynot01 ynot01 closed this Nov 30, 2023
@Yogbot-13 Yogbot-13 added the DME Edit This PR affects the yogstation.DME file label Nov 30, 2023
@PibeCantina
Copy link
Contributor

Add literally best pr tag please

@Joker66613 Joker66613 mentioned this pull request Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Config Config files need to be changed on the host for this to work DME Edit This PR affects the yogstation.DME file DO NOT MERGE Should not be merged without express approval from a Head Dev Feature This adds new content to the game Test Merge - Scheduled This PR is waiting to be test merged TESTMERGED This PR is currently live in a test merge. tgui This PR affects TGUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.