This repository was archived by the owner on May 22, 2025. It is now read-only.
TGUI Preferences Menu + total rewrite of the preferences backend #17368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatLing
added
DO NOT MERGE
Moltijoe
reviewed
Jan 6, 2023
| SPECIES_PERK_ICON = "gem", | ||
| SPECIES_PERK_NAME = "Crystal Core", | ||
| SPECIES_PERK_DESC = "The Ethereal's heart will encase them in crystal should they die, returning them to life after a time - \ | ||
| at the cost of a permanent brain trauma.", |
| SPECIES_PERK_TYPE = SPECIES_NEGATIVE_PERK, | ||
| SPECIES_PERK_ICON = "shower", | ||
| SPECIES_PERK_NAME = "Hydrophobia", | ||
| SPECIES_PERK_DESC = "Felinids don't like getting soaked with water.", |
Contributor
There was a problem hiding this comment.
i don't think they have any of these perks here, i will need to double check
| SPECIES_PERK_TYPE = SPECIES_NEGATIVE_PERK, | ||
| SPECIES_PERK_ICON = "sun", | ||
| SPECIES_PERK_NAME = "Radial Eyesight", | ||
| SPECIES_PERK_DESC = "Flypeople can be flashed from all angles.", |
Contributor
There was a problem hiding this comment.
we don't have sight angles so anyone can be flashed from all angles
| SPECIES_PERK_ICON = "briefcase-medical", | ||
| SPECIES_PERK_NAME = "Weird Organs", | ||
| SPECIES_PERK_DESC = "Flypeople take specialized medical knowledge to be \ | ||
| treated. Their organs are disfigured and organ manipulation can be interesting...", |
Contributor
There was a problem hiding this comment.
i don't THINK they have this here
| SPECIES_PERK_NAME = "Reformation", | ||
| SPECIES_PERK_DESC = "A boon quite similar to Ethereals, Mummies collapse into \ | ||
| a pile of bandages after they die. If left alone, they will reform back \ | ||
| into themselves. The bandages themselves are very vulnerable to fire.", |
Contributor
There was a problem hiding this comment.
not "similar to ethereals"
| SPECIES_PERK_TYPE = SPECIES_POSITIVE_PERK, | ||
| SPECIES_PERK_ICON = "bullhorn", | ||
| SPECIES_PERK_NAME = "Chain of Command", | ||
| SPECIES_PERK_DESC = "Nanotrasen only recognizes humans for command roles, such as Captain.", |
Contributor
There was a problem hiding this comment.
only for HoP and Captain, other command roles have some non-human species.
Maybe include better pay as one of the perks
| SPECIES_PERK_ICON = "tint", | ||
| SPECIES_PERK_NAME = "Jelly Blood", | ||
| SPECIES_PERK_DESC = "[plural_form] don't have blood, but instead have toxic [initial(exotic_blood.name)]! \ | ||
| Jelly is extremely important, as losing it will cause you to lose limbs. Having low jelly will make medical treatment very difficult.", |
Contributor
There was a problem hiding this comment.
should also mention inverted toxin damage
|
|
||
| /datum/species/preternis | ||
| name = "Preternis" | ||
| plural_form = "Preternis" |
| /datum/species/preternis/create_pref_unique_perks() | ||
| var/list/to_add = list() | ||
|
|
||
| // TODO |
Contributor
There was a problem hiding this comment.
probably something about
self surgery and self repair from being metal
Emp immunity
Eyes functioning to give night vision
Crippling weakness to water
Can't wear shoes, but have innate magboot abilities
purges all chems after a short time
reduced oxygen needed to breathe
Ideally try to roll some of these together to reduce bloat
Contributor
|
I don't like the idea of removing the Preferences tab, because that's packed already - moving it to the OOC tab will make that much worse |
Contributor
|
MOVING TO YOGS BRANCH |
Yogbot-13
added
Feature
Yogbot-13
added a commit
that referenced
this pull request
Jan 6, 2023
JamieD1
added a commit
that referenced
this pull request
Jan 28, 2023
) * TGUI Preferences Menu + total rewrite of the preferences backend (#17368) * It compiles * It opens * Sync 1 * Add asset caching * Sync 2 * It opens without dev now * Update a few packages * Sync 3 * Sync 4 keybind fix * start of dehardcoded species * Small fixes * Add more individual preferences * ASS sync * Automatic changelog generation #17368 [ci skip] * AHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH * e * Fix some TS stuff * Sort quirks starting from good * Fix skin tone selector * Jamie Fixes * Update moth.dm * Fix latejoin menu + tweaks * Some fixes * Finally fix job selection * e * Ling * MORE * config * Convert pref: ooccolor * Convert pref: asay color * Convert pref: tooltips * Convert pref: ui style * Convert pref: buttons locked * Convert pref: hotkeys * Convert pref: tgui stuff * Convert pref: windowflashing * Convert pref: ghost stuff * Convert pref: map & antag * Convert pref: PDA stuff * Convert pref: credits & glasses 1 * Convert pref: name * Convert pref: appearances 1 * Convert pref: appearances 2 * Convert pref: jobless role * Convert pref: runechat * Convert pref: yogtoggles + tail wagging 1 * Convert pref: client fps * Convert pref: graphic settings * Convert pref: pda uplink & menuoptions * Convert pref: map & flare * Convert pref: Bar choice * Fix setup character button * Convert pref: alt announcer * Fix * Add cycle background button * Convert pref: disable balloon alert * fix * Clean savefile * Fix backpack pref * Fix underwear selection * Fixes some shit * Updates * Fix computer runtime * Fix pref names * Convert pref: donor item & hat * More computer fixes * Convert pref: borg hat * Convert pref: donor pda (broken) * Convert pref: purrbation * Convert pref: afreeze * Convert pref: accent * Various savefile improvements * Convert pref: persistent scars 1 * A few pref fixes * Some more fixes * Various SSoverlays improvements * Add IPC appearances * Add polysmorph appearances * No icons for ipc and polysmorph * Podpeople deserve death * Add plasmaman appearance * h * fix * fix2 * asdf * fsdf * aaaaa * FUCK MOTHS * Preternis color * e * e * Update human.dmi * icon fix * un snowflake * fix underwear icon * remove color from here * donor ree * aa * maybe * Restore a bunch of TGUI files * More TGUI fixes * test * Fix more errors * a * test * e? * a;lso this * maybe * Fix * Revert "maybe" This reverts commit 14d044a. * fuck off m8 * e * fak off m8 * e2? * AHHH * AHA * AHHH * fix linter 2 * debug * fix runtime * Update dynamic.json * Revert "debug" This reverts commit 1868143. * 2 * who sleeps in an async? * Hack * e * Fix a few blocking calls * Oh bother * Stay dead * fuck * Update jobs.dm * move debugging * Update jobs.dm * Test * YEET * Revert "YEET" This reverts commit 4082e3b. * Update jobs.dm * Update jobs.dm * e * Fix sechailer runtime * Fix human hair color * d * Ports part of that job refactor * Convert latejoin to new departments * Fix ghost form * Quirk validation * Hopefully pod color fix * oops * Prayge job fix * test * Better unit test asset loading * Remove print * Add error just in case * Remove brief outfit and bypass centcom deadmin * Remove broadcast login/logout * Remove darkened flash * Remove fov darkness * Remove ghost lighting * Remove some tgui prefs * Typo fix * Small fixes * IPC name fix * IPC and pod colors * Jobless fix * Donor item fix * Oopsie * Quirk bandaid * Misc * Move new prefs to Preferences tab for now * Add skillcape * FUCK THIS SHIT * Remove /tg/ gamer cloak * Restrict some job related preferences to clean up UI * Remove useless client var * e * Small tweaks * Dont allow selecting mood quirks if mood is disabled * AHHH * Filter ckey-locked donor items * stupid jamie * AI core display fix * Move donor stuff back to the top * Remove TODOs * Clean up perks * Linter fixes * e * WORKS * LORE * Fix skillcape list * Backpack why * Fixes * Fix cargo console * Remove these * Add horns, frills and mark * Fix not applying all features * Add some missing mutant bodyparts * Update numberinput * Makes animatednumber cooler * Oops * Add default ghost orbit * Default to normal backpack * Fixes skillcapes not being filtered * Donor fix prayge * yep * Adds fallback latejoin menu * Rework donor stuff a bit * Fix donor tgui logic * Delete unused proc * Update FA * Un-yogify quirks * Better checking of quirks * Update tgfont * Fix quirk icons * Fix backup name * Fix donor stuff * A few runtime fixes * Fix another runtime * Give fallback latejoin verb upon connecting * Update AirAlarm interface * maybe this works * Test * Sentient * Remove AI core display preview icons * Fix resetting plasmaman helmet style * Equip plasman in preview * Fix plasmaman preview icon * fuck keybind fix * Extra keybind sanity --------- Co-authored-by: Yogbot-13 <[email protected]> Co-authored-by: Jamie D <[email protected]> Co-authored-by: TheGamerdk <[email protected]> Co-authored-by: adamsong <[email protected]>
This was referenced Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
So this, is a big one and will break a lot of stuff.
Mainly ports tgstation/tgstation#61313, which a whole bunch of extra stuff because we are so outdated. Currently still heavily WIP, so no screenshots yet. If you want to know what it looks like, go to the original PR.
Full list of ported PRs, credits to the original authors:
Changelog
🆑 Mothblocks & a lot of people from /tg/
rscadd: The preferences menu has been completely rewritten in tgui.
tweak: The "Preferences" tab has been removed, the menu verbs have been moved to the OOC tab
tweak: The "Stop Sounds" verb has been moved to OOC.
/:cl: